[bitbake-devel] [OE-core] [PATCH] bitbake: fetch: Extend subdir unpack parameter to local folder

[Christopher Larson]

On Mon, Sep 28, 2015 at 6:11 AM, Ming Liu <liu.ming50 at gmail.com> wrote:

> +                    if urldata.parm.get('subdir') != None:
> +                        destdir = urldata.parm.get('subdir') + "/" +
> destdir
>

If you really care about the difference between None and the empty string,
then this should be 'is not None', not '!= None', but most likely you
don't, in which case 'if urldata.parm.get('subdir')' is sufficient, and
cleaner. Also you do the parm.get() twice, it may be better to store that
in a variable.
-- 
Christopher Larson
clarson at kergoth dot com
Founder - BitBake, OpenEmbedded, OpenZaurus
Maintainer - Tslib
Senior Software Engineer, Mentor Graphics
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openembedded.org/pipermail/bitbake-devel/attachments/20151003/56ced020/attachment-0002.html>