[bitbake-devel] [PATCH] bitbake-worker: Simple code cleanup

Richard Purdie richard.purdie at linuxfoundation.org
Tue Sep 8 22:36:49 UTC 2015


start/end are unused here and we can improve the code conditional blocks.

Signed-off-by: Richard Purdie <richard.purdie at linuxfoundation.org>

diff --git a/bitbake/bin/bitbake-worker b/bitbake/bin/bitbake-worker
index 305f87c..df59953 100755
--- a/bitbake/bin/bitbake-worker
+++ b/bitbake/bin/bitbake-worker
@@ -296,13 +296,12 @@ class BitbakeWorker(object):
     def serve(self):        
         while True:
             (ready, _, _) = select.select([self.input] + [i.input for i in self.build_pipes.values()], [] , [], 1)
-            if self.input in ready or len(self.queue):
-                start = len(self.queue)
+            if self.input in ready:
                 try:
                     self.queue = self.queue + self.input.read()
                 except (OSError, IOError):
                     pass
-                end = len(self.queue)
+            if len(self.queue):
                 self.handle_item("cookerconfig", self.handle_cookercfg)
                 self.handle_item("workerdata", self.handle_workerdata)
                 self.handle_item("runtask", self.handle_runtask)





More information about the bitbake-devel mailing list