[bitbake-devel] [PATCH] BB_NO_NETWORK: Fallback to local source for git lsremote

[Jérémy Rosen]

On 08/08/2016 17:35, Khem Raj wrote:
>> On Aug 8, 2016, at 4:24 AM, Jérémy Rosen <jeremy.rosen at smile.fr> wrote:
>>
>>
>> On 08/08/2016 11:55, Richard Purdie wrote:
>>> On Mon, 2016-08-08 at 08:34 +0000, Tobias Hagelborn wrote:
>>>> Change made to enable building offline also with git tag references
>>>> in SRC_URI.
>>>>
>>>> If BB_NO_NETWORK is set, fallback to search for tags and revisions
>>>> in local DL_DIR / GITDIR in order to avoid network access.
>>> I'm not sure I agree with this since you'd get different build results
>>> depending on whether BB_NO_NETWORK is set or not.
>>>
>>> I think if BB_NO_NETWORK is set, its reasonable to assume that the
>>> configuration should be locked down and that BB_NO_NETWORK should not
>>> have other side effects like this.
>>>
>>> It would also make it very hard to detect unlocked configurations
>>> during testing which currently are quite easily identified.
>> To be honest, this is a real world problem I have on a regular basis...
>>
>> The problem we have is that our customers want to keep an archive for (very) long term support and they test offline mode.
>>
>> This problem means that we have to set all our SRC_URI to git SHA instead of the much more readable and easy to check git tags.
>>
>>
>> you think to assume that a reference is a branch, but the real-life problem is when reference is a tag. Tag don't move so this is
>> a case of locked configuration, but i'm not sure how to handle it.
>>
>> Is there a way to have the best of both world somehow ?
> Don’t use tags instead rely on SHA numbers in SRCREV and use
> BB_GENERATE_MIRROR_TARBALLS like mentioned here
>
> https://wiki.yoctoproject.org/wiki/How_do_I#Q:_How_do_I_create_my_own_source_download_mirror_.3F
>
> tags are floating types in git, you can not use them reliably.
> You may tool in a method to automate updating the
> recipes SRCREVs if you dont want to do it by hand.
>
> That should help hopefully
I know... but the fact that NO_NETWORK can't work if any git uses a tag 
seems... not what I would expect. Especially if the tag is available 
locally. I understand what you say, but I think it breaks the purpose of 
NO_NETWORK

If a git reference is floating, then building twice won't produce the 
same result anyway... this sounds more like a QA problem to me than 
something that bitbake should enforce. But i'm really not a BB 
architect, it's just that this patch would solve one of our problem and 
i'd like to see if there is a way to do that without loosing other 
aspects of bitbake...