[bitbake-devel] [PATCH 1/1] add a syntax to clear variable

[Ulf.Magnusson at bmw.de]

Hello,

> -----Original Message-----
> From: bitbake-devel-bounces at lists.openembedded.org [mailto:bitbake-
> devel-bounces at lists.openembedded.org] On Behalf Of Jérémy Rosen
> Sent: den 21 juli 2016 12:56
> To: bitbake-devel at lists.openembedded.org
> Cc: Jérémy Rosen
> Subject: [bitbake-devel] [PATCH 1/1] add a syntax to clear variable
>
> From: Jérémy Rosen <jeremy.rosen at openwide.fr>
>
> unset VAR
> will clear variable VAR
> unset VAR[flag]
> will clear flag "flag" from var VAR
>
> Signed-off-by: Jérémy Rosen <jeremy.rosen at openwide.fr>
> ---
>  .../bitbake-user-manual-metadata.xml               | 17 +++++++++++
>  bitbake/lib/bb/parse/ast.py                        | 33
> ++++++++++++++++++++++
>  bitbake/lib/bb/parse/parse_py/ConfHandler.py       | 12 ++++++++
>  3 files changed, 62 insertions(+)
>
> diff --git a/bitbake/doc/bitbake-user-manual/bitbake-user-manual-
> metadata.xml b/bitbake/doc/bitbake-user-manual/bitbake-user-manual-
> metadata.xml
> index 6329cd6..c42907e 100644
> --- a/bitbake/doc/bitbake-user-manual/bitbake-user-manual-metadata.xml
> +++ b/bitbake/doc/bitbake-user-manual/bitbake-user-manual-metadata.xml
> @@ -333,6 +333,23 @@
>              </para>
>          </section>
>
> +        <section id='unseting-variables'>

"Unsetting" is spelled with two t's.

> +            <title>Unseting variables</title>
> +
> +            <para>
> +                It is possible to completely remove a variable or a
> variable flag
> +                from BitBake's internal data dictionary using the
> "unset" keyword

There's a missing period at the end of this sentence, and "by using"
sounds a bit better.

> +                Here is an example:
> +                <literallayout class='monospaced'>
> +        unset DATE
> +        unset do_fetch[noexec]
> +                </literallayout>
> +                This example results in the <filename>DATE</filename>
> being unset and the flag
> +                <filename>do_fetch[noexec]</filename> to be cleared

"These two statements remove the DATE variable and the do_fetch[noexec]
variable flag" is better. "...results in... to be cleared" sounds weird.

Cheers,
Ulf