[bitbake-devel] [PATCH] runqueue: Abstract worker functionality to an object/array

[Christopher Larson]

On Tue, Aug 16, 2016 at 6:46 AM, Richard Purdie <
richard.purdie at linuxfoundation.org> wrote:

> On Mon, 2016-08-15 at 10:16 -0700, Christopher Larson wrote:
> >
> > On Mon, Aug 15, 2016 at 9:58 AM, Richard Purdie <
> > richard.purdie at linuxfoundation.org> wrote:
> > > +                    if w in self.rq.worker:
> > > +                        name = "Worker"
> > > +                    elif w in self.rq.fakeworker:
> > > +                        name = "Fakeroot"
> > >
> > The concept seems sound, but there's still a fair bit of handling
> > which is do this thing for workers and that thing for fake workers,
> > makes me think we might want to split out objects to bind the
> > workers, their names, and their logic.
>
> I agree and there is certainly room for improvement. I think the patch
> as it stands is probably a good first step and there are more that can
> be made on top of it, I'm open to them or may get around to it myself
> eventually if nobody else does. Part of the trouble I've had in doing
> this is not to get distracted from the multi-config work which
> necessitated it in the first place!


Agreed. This is a step in the right direction.
-- 
Christopher Larson
clarson at kergoth dot com
Founder - BitBake, OpenEmbedded, OpenZaurus
Maintainer - Tslib
Senior Software Engineer, Mentor Graphics
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openembedded.org/pipermail/bitbake-devel/attachments/20160816/10221148/attachment-0002.html>