[bitbake-devel] [PATCH] bitbake warning fix: No bb files matched BBFILE_PATTERN_packageName

[Mounesh Sutar]

Hi,
Adding more information about this issue.
For example, consider below recipes with respective Pattern Name and
priority.

Package Name           Recipe file path
 BBFILE_PATTERN                    Priority

alsa                           /Projects/abc/alsa
/Projects/abc/alsa                            160
layer-man                 /Projects/abc/layer-man
/Projects/abc/layer-man                  150
xyz                            /Projects/abc/xyz
   /Projects/abc/xyz                             130
gpu-viv                      /Projects/abc/xyz/gpu-viv
/Projects/abc/xyz/gpu-viv                 130
update-1                   /Projects/abc/xyz/update-1
/Projects/abc/xyz/update-1              130
update-2                   /Projects/abc/xyz/update-2
/Projects/abc/xyz/update-2              130


If we consider the case of parsing alsa recipe, with its file name parsing
against all patterns, it would find matching pattern("/Projects/abc/alsa ")
and parse successfully.
Similarly the case with layer-man recipes.
When it comes to case of xyz, it does parses like other alsa recipe, as it
would find matching pattern("/Projects/abc/xyz") to its file name.
When it picks up next gpu-viv recipe file("/Projects/abc/xyz/gpu-viv/*/*.bb"),
and starts parsing against all PATTERNs,
on finding pattern "/Projects/abc/xyz", the condition :
"if regex.match(filename):"

will succeed, as partial file name "/Projects/abc/xyz/gpu-viv" matches to
it.
So, it is not matching against correct pattern ("Projects/abc/xyz/gpu-viv").
This is causing remaining recipes of folder "xyz" are not being parsed
against all patterns.
By current change, it will force to parse all recipe files against all
PATTERN's and store matching patterns.

Regards,
Mounesh

On Tue, Sep 27, 2016 at 11:54 AM, Mounesh Sutar <mounesh.sutar at gmail.com>
wrote:

> From: Mounesh Sutar <mounesh_sutar at mentor.com>
>
> bitbake is parsing all recipe files, against layers BBFILE_PATTERN for
> warning message display.
> In case of sublayer with lower/equal priority, then all sublayer's
> patterns are not being
> considered for pattern match. While checking recipe file against matching
> pattern,
> the first matching pattern is accepted and added to matched list, while
> remaning PATTERNs are
> not being considered. With this, the recipes are being neglected from
> PATTERN match.
> This fix let's parser run through all the layers PATTERNs and on matching
> added to match list.
>
> Upstream-Status: Submitted [bitbake-devel at lists.openembedded.org]
>
> Signed-off-by: Mounesh Sutar <mounesh_sutar at mentor.com>
> ---
>  bitbake/lib/bb/cooker.py |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/bitbake/lib/bb/cooker.py b/bitbake/lib/bb/cooker.py
> index 4df8881..5fde995 100644
> --- a/bitbake/lib/bb/cooker.py
> +++ b/bitbake/lib/bb/cooker.py
> @@ -1705,7 +1705,7 @@ class CookerCollectFiles(object):
>                  if matched != None:
>                      if not regex in matched:
>                          matched.add(regex)
> -                return pri
> +                        return pri
>          return 0
>
>      def get_bbfiles(self):
> --
> 1.7.9.5
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openembedded.org/pipermail/bitbake-devel/attachments/20161208/428438de/attachment-0002.html>