[bitbake-devel] [PATCH] bitbake: remove True option to getVar calls (take 2)

[Joshua Lock]

getVar() now defaults to expanding by default, thus remove the True
option from getVar() calls with a regex search and replace.

Search made with the following regex: getVar ?\(( ?[^,()]*), True\)

(a follow on patch to fix up a few recent introductions)

Signed-off-by: Joshua Lock <joshua.g.lock at intel.com>
---
 lib/bb/server/process.py | 2 +-
 lib/bb/siggen.py         | 2 +-
 lib/bb/tests/data.py     | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/lib/bb/server/process.py b/lib/bb/server/process.py
index 1036366..c9dfb4f 100644
--- a/lib/bb/server/process.py
+++ b/lib/bb/server/process.py
@@ -103,7 +103,7 @@ class ProcessServer(Process, BaseImplServer):
             self.event_queue.put(event)
         self.event_handle.value = bb.event.register_UIHhandler(self, True)
 
-        heartbeat_event = self.cooker.data.getVar('BB_HEARTBEAT_EVENT', True)
+        heartbeat_event = self.cooker.data.getVar('BB_HEARTBEAT_EVENT')
         if heartbeat_event:
             try:
                 self.heartbeat_seconds = float(heartbeat_event)
diff --git a/lib/bb/siggen.py b/lib/bb/siggen.py
index b20b9cf..659d27d 100644
--- a/lib/bb/siggen.py
+++ b/lib/bb/siggen.py
@@ -101,7 +101,7 @@ class SignatureGeneratorBasic(SignatureGenerator):
 
     def _build_data(self, fn, d):
 
-        ignore_mismatch = ((d.getVar("BB_HASH_IGNORE_MISMATCH", True) or '') == '1')
+        ignore_mismatch = ((d.getVar("BB_HASH_IGNORE_MISMATCH") or '') == '1')
         tasklist, gendeps, lookupcache = bb.data.generate_dependencies(d)
 
         taskdeps = {}
diff --git a/lib/bb/tests/data.py b/lib/bb/tests/data.py
index ba30d12..0903ba7 100644
--- a/lib/bb/tests/data.py
+++ b/lib/bb/tests/data.py
@@ -465,7 +465,7 @@ class Serialize(unittest.TestCase):
         os.remove(tmpfilename)
 
         self.assertEqual(d, newd)
-        self.assertEqual(newd.getVar('HELLO', True), 'world')
+        self.assertEqual(newd.getVar('HELLO'), 'world')
         self.assertEqual(newd.getVarFlag('HELLO', 'other'), 'planet')
 
 
-- 
2.9.3