[bitbake-devel] bitbake-prserv should not force umask in daemon mode

[Diego Santa Cruz]

Hi there,

And yet one more fix for the PR Service, this is the last one I've found :) For the record I stumbled across this series of issues (this and past e-mails from today) while setting up a shared PR Service for our internal builds.

As reported in bug #9036 [1] clearing the umask when daemonizing the PR Service is not a good idea. The attached patch removes this from the daemonize code.

The description I entered in the bug report is the following.

The current bitbake-prserv forces the umask to 0 when daemonizing.

I think his should not be done, as it will make all files be created with permissions 0777 (world writable!) by default.

For instance, the PID file (/tmp/PRServer_*.pid) is created with permissions 0777 on my system (CentOS 7.2.1511).

It would be better to leave the umask unchanged, so whoever is starting bitbake-preserv gets to choose the umask it wants to use.

The attached patch does exactly this.

Best regards,

Diego

[1] https://bugzilla.yoctoproject.org/show_bug.cgi?id=9036
--
Diego Santa Cruz, PhD
Technology Architect
T +41 21 341 15 50
diego.santacruz at spinetix.com
spinetix.com

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openembedded.org/pipermail/bitbake-devel/attachments/20160202/bafcbb2a/attachment-0002.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-bitbake-prserv-do-not-clear-umask-when-daemonizing.patch
Type: application/octet-stream
Size: 1115 bytes
Desc: 0001-bitbake-prserv-do-not-clear-umask-when-daemonizing.patch
URL: <http://lists.openembedded.org/pipermail/bitbake-devel/attachments/20160202/bafcbb2a/attachment-0002.obj>