[bitbake-devel] [Openembedded-architecture] [PATCH] data_smart: Drop default expand=False to getVarFlag [API change]

[Khem Raj]

On Tue, Feb 2, 2016 at 3:55 PM, Richard Purdie
<richard.purdie at linuxfoundation.org> wrote:
> At some point in the future, getVarFlag should expand by default. To
> get there from the current position, we need a period of time where the
> expand parameter is mandatory.
>

what are advantages of this.

> This patch starts that process. Clear errors will result from any code
> which doesn't provide this. Layers can be fixed with an expression
> like:
>
> sed -e 's:\(\.getVarFlag([^,()]*, [^,()]*\)):\1, False):g' -i `grep -ril getVar *`
>
> Signed-off-by: Richard Purdie <richard.purdie at linuxfoundation.org>
> diff --git a/bitbake/lib/bb/data_smart.py b/bitbake/lib/bb/data_smart.py
> index 79bec1b..d61ad53 100644
> --- a/bitbake/lib/bb/data_smart.py
> +++ b/bitbake/lib/bb/data_smart.py
> @@ -663,7 +663,7 @@ class DataSmart(MutableMapping):
>                  self.dict["__exportlist"]["_content"] = set()
>              self.dict["__exportlist"]["_content"].add(var)
>
> -    def getVarFlag(self, var, flag, expand=False, noweakdefault=False, parsing=False):
> +    def getVarFlag(self, var, flag, expand, noweakdefault=False, parsing=False):
>          local_var = self._findVar(var)
>          value = None
>          if flag == "_content" and var in self.overridedata and not parsing:
>
>
> _______________________________________________
> Openembedded-architecture mailing list
> Openembedded-architecture at lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-architecture