[bitbake-devel] [Openembedded-architecture] [PATCH] data_smart: Drop default expand=False to getVarFlag [API change]

[Khem Raj]

On Wed, Feb 3, 2016 at 12:00 AM, Richard Purdie
<richard.purdie at linuxfoundation.org> wrote:
> On Tue, 2016-02-02 at 21:36 -0800, Khem Raj wrote:
>> On Tue, Feb 2, 2016 at 3:55 PM, Richard Purdie
>> <richard.purdie at linuxfoundation.org> wrote:
>> > At some point in the future, getVarFlag should expand by default.
>> > To
>> > get there from the current position, we need a period of time where
>> > the
>> > expand parameter is mandatory.
>> >
>>
>> what are advantages of this.
>
> Most users expect the data to be expanded by default. Most call sites
> also use getVar(xxx, True), its uncommon to see expand=False, outside
> the core of bitbake.
>
> So the ultimate advantage is a more sensible default which is what the
> user expects and leads to neater/smaller code.
>

That makes sense.

> We have had several bugs requesting this and it does confuse people.
>
> I have heard regrets from some of the original developers that the
> default wasn't True as well.
>
> Cheers,
>
> Richard
>