[bitbake-devel] [PATCH 2/2] data_smart: handle '\x7d' in python parsing

[Richard Purdie]

On Thu, 2016-02-04 at 08:39 +0200, Markus Lehtonen wrote:
> On 03/02/16 18:52, "Richard Purdie" <
> richard.purdie at linuxfoundation.org> wrote:
> 
> > On Wed, 2016-02-03 at 12:33 +0200, Markus Lehtonen wrote:
> > > At least ncurses recipe uses a workaround (for former bitbake
> > > python
> > > parser) where closing curly bracket inside a python string was
> > > replaced
> > > by '\x7d' ascii code. The previous "curly bracket matching" patch
> > > broke
> > > parsing of constructs like this as bitbake wouldn't correctly
> > > find
> > > the
> > > closing bracket. This patch fixes this by accepting '\x7d' as a
> > > closing
> > > bracket.
> > > 
> > > Hopefully, this patch could be reverted (and the python regexp
> > > thus
> > > simplified) in the future after making sure that no recipes use
> > > the
> > > '\x7d' workaround, anymore.
> > > 
> > > [YOCTO #8849]
> > > 
> > > Signed-off-by: Markus Lehtonen <markus.lehtonen at linux.intel.com>
> > > ---
> > >  lib/bb/data_smart.py | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > To be honest, the number of recipes which do this is hopefully very
> > very small and we should just go and fix them now?
> 
> I was pondering this, too, but tried to make sure not to break
> anything. I can e.g. grep through the layers in git.openembedded.org
> and git.yoctoproject.org and see if there are any other recipes like
> this and submit patches to change those.

I think that might be the better option, thanks!

Richard