[bitbake-devel] [Openembedded-architecture] [PATCH] data_smart: Drop default expand=False to getVar [API change]

[Paul Eggleton]

On Tue, 02 Feb 2016 23:55:40 Richard Purdie wrote:
> At some point in the future, getVar should expand by default. To get
> there from the current position, we need a period of time where the
> expand parameter is mandatory.
> 
> This patch starts that process. Clear errors will result from any code
> which doesn't provide this. Layers can be fixed with an expression
> like:
> 
> sed -e 's:\(\.getVar([^,()]*, [^,()]*\)):\1, False):g' -i `grep -ril getVar
> *`
> 
> Signed-off-by: Richard Purdie <richard.purdie at linuxfoundation.org>
> 
> diff --git a/bitbake/lib/bb/data_smart.py b/bitbake/lib/bb/data_smart.py
> index 8c3e9ef..79bec1b 100644
> --- a/bitbake/lib/bb/data_smart.py
> +++ b/bitbake/lib/bb/data_smart.py
> @@ -566,7 +566,7 @@ class DataSmart(MutableMapping):
>                  if len(shortvar) == 0:
>                      override = None
> 
> -    def getVar(self, var, expand=False, noweakdefault=False,
> parsing=False): +    def getVar(self, var, expand, noweakdefault=False,
> parsing=False): return self.getVarFlag(var, "_content", expand,
> noweakdefault, parsing)
> 
>      def renameVar(self, key, newkey, **loginfo):

This change is reasonable and we've been discussing it on and off for years 
now, so I'm generally in favour.

However, what I would really like to see us do is write a script that people 
can use to upgrade their layers to accommodate this and any other breaking 
changes so they don't have to go and figure out what to do themselves; the more 
of these kinds of changes we make the more useful this script will be. I'll 
file a bug.

Cheers,
Paul

-- 

Paul Eggleton
Intel Open Source Technology Centre