[bitbake-devel] [PATCH] bb/fetch2: broken functionality for entries like file://dir; subdir=foo in SRC_URI

[Sasha Shashkevich]

> On Feb 22, 2016, at 22:51, Richard Purdie <richard.purdie at linuxfoundation.org> wrote:
> 
> On Mon, 2016-02-22 at 20:34 +0200, Alexander Shashkevich wrote:
>> For SRC_URI entries like file://dir1;subdir=foo1 and
>> file://dir2/dir3;subdir=foo2/foo3
>> subdirectories ${WORKDIR}/foo1 and ${WORKDIR}/foo2/foo3 are created,
>> but dir1 and dir2/dir3 are
>> only copied to ${WORKDIR}/dir1 and ${WORKDIR}/dir2/dir. Correct way:
>> directories must be copied/unpacked
>> into '${WORKDIR}/foo1/dir1' and '${WORKDIR}/foo2/foo3/dir2/dir'
>> respectively.
> 
> Where we have cases like this, I'd ask that you add a test case to
> lib/bb/tests/ which illustrates the problem and ensures we don't
> regress in future. We've had far too many problems with corner cases
> and the fetcher :(
> 
> I need to properly review the patch but wanted to mention this now.

Good point. Just launched test cases for my changes and one regression appeared. Bad. I'll fix regression and add test cases.

Thank you. :)

Alexander