[bitbake-devel] [PATCH] fetch/git: Change to use clearer ssh url syntax for broken servers

[Peter Kjellerstedt]

> -----Original Message-----
> From: bitbake-devel-bounces at lists.openembedded.org [mailto:bitbake-
> devel-bounces at lists.openembedded.org] On Behalf Of Richard Purdie
> Sent: den 13 januari 2016 23:20
> To: Andre McCurdy
> Cc: bitbake-devel
> Subject: Re: [bitbake-devel] [PATCH] fetch/git: Change to use clearer
> ssh url syntax for broken servers
> 
> On Wed, 2016-01-13 at 13:37 -0800, Andre McCurdy wrote:
> > On Thu, Jan 7, 2016 at 5:18 AM, Richard Purdie
> > <richard.purdie at linuxfoundation.org> wrote:
> > > Some servers, e.g. bitbucket.org can't cope with ssh:// as part of
> > > the git url syntax. git itself is happy enough with this but you
> > > get server side errors when using it.
> > >
> > > This changes the git fetcher to use the more common ssh url format
> > > which also means we need a : before the path.
> >
> > This seems to break SRC_URIs using ssh to access self hosted git
> > servers setup following the process described here:
> >
> >   https://git-scm.com/book/en/v2/Git-on-the-Server-Setting-Up-the-Ser
> > ver
> >
> > An example of such a SRC_URI, which now fails to work:
> >
> >   SRC_URI = "git
> > ://git at mylocalserver.com:/opt/git/myrepo.git;protocol=ssh"
> 
> Does:
> 
> SRC_URI = "git://git@mylocalserver.com/opt/git/myrepo.git;protocol=ssh"
> 
> work though?

The above may work, but this does not any more:

SRC_URI = "git://git@mylocalserver.com:12345/opt/git/myrepo.git;protocol=ssh"

I.e., when the Git server requires a port, like our Gerrit server does...
Please revert the commit and solve the actual problem with bitbucket.org 
some other way.

> I'm not sure we ever suggested people should use ":/" in SRC_URI since
> that isn't a url format the system was ever designed to cope with. It
> might have happened to work but that is different...
> 
> Cheers,
> 
> Richard

//Peter