[bitbake-devel] [PATCH] fetch/git: Change to use clearer ssh url syntax for broken servers

[Andre McCurdy]

On Thu, Jan 14, 2016 at 7:25 AM, Richard Purdie
<richard.purdie at linuxfoundation.org> wrote:
> On Thu, 2016-01-14 at 14:47 +0000, Peter Kjellerstedt wrote:
>> > -----Original Message-----
>> > From: bitbake-devel-bounces at lists.openembedded.org [mailto:bitbake-
>> > devel-bounces at lists.openembedded.org] On Behalf Of Richard Purdie
>> > Sent: den 13 januari 2016 23:20
>> > To: Andre McCurdy
>> > Cc: bitbake-devel
>> > Subject: Re: [bitbake-devel] [PATCH] fetch/git: Change to use
>> > clearer
>> > ssh url syntax for broken servers
>> >
>> > On Wed, 2016-01-13 at 13:37 -0800, Andre McCurdy wrote:
>> > > On Thu, Jan 7, 2016 at 5:18 AM, Richard Purdie
>> > > <richard.purdie at linuxfoundation.org> wrote:
>> > > > Some servers, e.g. bitbucket.org can't cope with ssh:// as part
>> > > > of
>> > > > the git url syntax. git itself is happy enough with this but
>> > > > you
>> > > > get server side errors when using it.
>> > > >
>> > > > This changes the git fetcher to use the more common ssh url
>> > > > format
>> > > > which also means we need a : before the path.
>> > >
>> > > This seems to break SRC_URIs using ssh to access self hosted git
>> > > servers setup following the process described here:
>> > >
>> > >   https://git-scm.com/book/en/v2/Git-on-the-Server-Setting-Up-the
>> > > -Ser
>> > > ver
>> > >
>> > > An example of such a SRC_URI, which now fails to work:
>> > >
>> > >   SRC_URI = "git
>> > > ://git at mylocalserver.com:/opt/git/myrepo.git;protocol=ssh"
>> >
>> > Does:
>> >
>> > SRC_URI = "git
>> > ://git at mylocalserver.com/opt/git/myrepo.git;protocol=ssh"
>> >
>> > work though?
>>
>> The above may work, but this does not any more:
>>
>> SRC_URI = "git
>> ://git at mylocalserver.com:12345/opt/git/myrepo.git;protocol=ssh"
>>
>> I.e., when the Git server requires a port, like our Gerrit server
>> does...
>> Please revert the commit and solve the actual problem with
>> bitbucket.org
>> some other way.
>
> I'm not sure there is one other than special casing bitbucket urls in
> the fetcher.

But I don't think there is any problem with BitBucket. The original
bug report was caused by trying to use a URL with a ':' between the
host and the repo path. A URL like that does not work when prefixed by
ssh://, it's the same for GitHub URLs too.

> With Andre's case, we clearly don't support cut and paste of urls into
> SRC_URI so I'm less concerned about that but the above is more of an
> issue.
>
> The url parsing in the fetcher should really be aware of port numbers
> and I suspect if we do that, we can fix the above. I'm not going to
> instantly revert the other change over this.
>
> I'd also state that if you expect particular syntaxes to work, I'd
> strongly encourage they're in the selftests for the fetcher. The self
> tests didn't show any regressions...
>
> Cheers,
>
> Richard
>