[bitbake-devel] [PATCH] Fix bug 8940 - Alow Hob to run images on a custom simulator, other than qemu

[Joshua G Lock]

Hi Mirela,

On Thu, 2016-01-21 at 15:52 +0000, Mirela Rabulea wrote:
> Hi,
> I have been told that Hob is deprecated and to be replaced by
> Toaster, still I have some changes already made on Hob, which I would
> like to push. Besides that, I understand that at this moment Toaster
> cannot run images at all, via a button push.
> I would be happy if these changes make it into YP 2.1, M2 or at least
> M3.

Thanks for taking the time to develop and submit this change.

Whilst Hob is not under active development I'm not aware of a timeline
for removing it from the repository, thus I'd welcome improvements and
bug fixes.

> The current behavior of Hob is that there is a "Run Image" button
> which becomes visible only for qemu images.
>  
> My suggested change is:
> - if an image is selected and it is , let the "Run image" button be
> named "Run qemu image"

I think you meant "and it is qemu-compatible,"?

> - if an image is selected and it is not qemu-compatible, let the same
> button show up with the name "Run custom image", and besides that, an
> option shows-up to allow the selection of the custom script (by
> default it points out to runqemu script) to be used for launching
> this custom image
>  
> Associated bug:
> https://bugzilla.yoctoproject.org/show_bug.cgi?id=8940
>  
> Related bug (feaure request):
> https://bugzilla.yoctoproject.org/show_bug.cgi?id=8959
>  
>  
> Thanks Belen, Bogdan and Alexandru for helping me on this.

On an initial look this change looks good, I have a couple of minor
comments on the UI:

FILE_CHOOSER_ACTION_SAVE seems wrong, I think this should use
FILE_CHOOSER_ACTION_OPEN as we only want to select existing files. 

See:
https://developer.gnome.org/pygtk/stable/gtk-constants.html#gtk-filecho
oser-action-constants

Also I think we'd probably want to use something other than "Open" to
confirm selection of the emulator, but that's more of a question for
Belen. Personally I think "Select" or "Choose" makes more sense.

When I ran Hob with your change I noticed the "Run script:" detail is
positioned vertically in the middle of its parent box, the other boxes
in the "Image details" page have their content at the top of the parent
box — could you change that?

When you submit your v2 could you send the patch directly, rather than
as an attachment. This allows us to perform any review in-line in an
email reply.

You can use either the scripts in the openembedded-core repository
(scripts/[create|send]-pull-request) or git send-email directly.

Furthermore as the patch, when ready, will be applied directly to the
bitbake repository it would be useful to improve the commit message in
line with the OpenEmbedded recommendations: 
http://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines

Specifically could you:
* include some detail in the commit message,
perhaps use the reasoning above?
* move the bug ID to the bottom of the
commit message, above the signed-off-by. It should be formatted as:
[YOCTO #8940]
* Fix the typo in the one-line description "Alow" ->
"Allow"

Of course having written this I realise we don't have a good resource
for BitBake contribution guidelines I've filed a bug in the Yocto
Project bugzilla to ensure we develop some guidelines for contributing
to the BitBake repository: 
https://bugzilla.yoctoproject.org/show_bug.cgi?id=9007

Thanks again for submitting this patch, I look forward to seeing v2!

Regards,

Joshua