[bitbake-devel] [PATCH 4/7] eventreplay: replace MockConfigParameters with namedtuple
Elliot Smith
elliot.smith at intel.com
Wed Jul 6 11:00:32 UTC 2016
From: Ed Bartosh <ed.bartosh at linux.intel.com>
class MockConfigParameters has only one attribute and only __init__
method. Replacing it with namedtuple makes code less nested and more
readable.
[YOCTO #9585]
Signed-off-by: Ed Bartosh <ed.bartosh at linux.intel.com>
Signed-off-by: Elliot Smith <elliot.smith at intel.com>
---
bin/toaster-eventreplay | 14 ++------------
1 file changed, 2 insertions(+), 12 deletions(-)
diff --git a/bin/toaster-eventreplay b/bin/toaster-eventreplay
index a107298..b9ab79e 100755
--- a/bin/toaster-eventreplay
+++ b/bin/toaster-eventreplay
@@ -30,6 +30,7 @@ from __future__ import print_function
import os
import sys, logging
import codecs
+from collections import namedtuple
# mangle syspath to allow easy import of modules
sys.path.insert(0, os.path.join(os.path.dirname(os.path.dirname(os.path.abspath(__file__))),
@@ -159,17 +160,6 @@ class FileReadEventsServerConnection():
self.events = FileReadEventsServerConnection.EventReader(self)
-
-
-
-
-class MockConfigParameters():
- """ stand-in for cookerdata.ConfigParameters; as we don't really config a cooker, this
- serves just to supply needed interfaces for the toaster ui to work """
- def __init__(self):
- self.observe_only = True # we can only read files
-
-
# run toaster ui on our mock bitbake class
if __name__ == "__main__":
if len(sys.argv) < 2:
@@ -178,7 +168,7 @@ if __name__ == "__main__":
file_name = sys.argv[-1]
mock_connection = FileReadEventsServerConnection(file_name)
- configParams = MockConfigParameters()
+ configParams = namedtuple('ConfigParams', ['observe_only'])(True)
# run the main program and set exit code to the returned value
sys.exit(toasterui.main(mock_connection.connection, mock_connection.events, configParams))
--
2.7.4
More information about the bitbake-devel
mailing list