[bitbake-devel] [PATCH] xmlrpc: fix bug in setting XMLRPCServer.single_use

[Joshua G Lock]

On Fri, 2016-03-04 at 10:13 +0200, Ed Bartosh wrote:
> XMLRPCServer.single_use attribute was always set to False.
> This caused xmlrpc server to keep running after build is done as
> BitBakeServerCommands.removeClient only shuts down server if its
> single_use attribute is set to True.
> 
> Signed-off-by: Ed Bartosh <ed.bartosh at linux.intel.com>
> ---
>  bitbake/lib/bb/server/xmlrpc.py | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/bitbake/lib/bb/server/xmlrpc.py
> b/bitbake/lib/bb/server/xmlrpc.py
> index 1ceca51..d627550 100644
> --- a/bitbake/lib/bb/server/xmlrpc.py
> +++ b/bitbake/lib/bb/server/xmlrpc.py
> @@ -193,6 +193,8 @@ class XMLRPCServer(SimpleXMLRPCServer,
> BaseImplServer):
>          BaseImplServer.__init__(self)
>          if (interface[1] == 0):     # anonymous port, not getting
> reused
>              self.single_use = True
> +        else:
> +            self.singe_use = False

This won't work, right? Typo.

Regards,

Joshua

>          # Use auto port configuration
>          if (interface[1] == -1):
>              interface = (interface[0], 0)
> @@ -205,7 +207,6 @@ class XMLRPCServer(SimpleXMLRPCServer,
> BaseImplServer):
>          self.commands = BitBakeServerCommands(self)
>          self.autoregister_all_functions(self.commands, "")
>          self.interface = interface
> -        self.single_use = False
>  
>      def addcooker(self, cooker):
>          BaseImplServer.addcooker(self, cooker)
> -- 
> 2.1.4
>