[bitbake-devel] [PATCH] xmlrpc: fix bug in setting XMLRPCServer.single_use

[Ed Bartosh]

On Fri, Mar 04, 2016 at 03:20:12PM +0000, Peter Kjellerstedt wrote:
> > -----Original Message-----
> > From: bitbake-devel-bounces at lists.openembedded.org [mailto:bitbake-
> > devel-bounces at lists.openembedded.org] On Behalf Of Joshua G Lock
> > Sent: den 4 mars 2016 11:30
> > To: bitbake-devel at lists.openembedded.org
> > Subject: Re: [bitbake-devel] [PATCH] xmlrpc: fix bug in setting
> > XMLRPCServer.single_use
> > 
> > On Fri, 2016-03-04 at 10:13 +0200, Ed Bartosh wrote:
> > > XMLRPCServer.single_use attribute was always set to False.
> > > This caused xmlrpc server to keep running after build is done as
> > > BitBakeServerCommands.removeClient only shuts down server if its
> > > single_use attribute is set to True.
> > >
> > > Signed-off-by: Ed Bartosh <ed.bartosh at linux.intel.com>
> > > ---
> > >  bitbake/lib/bb/server/xmlrpc.py | 3 ++-
> > >  1 file changed, 2 insertions(+), 1 deletion(-)
> > >
> > > diff --git a/bitbake/lib/bb/server/xmlrpc.py
> > > b/bitbake/lib/bb/server/xmlrpc.py
> > > index 1ceca51..d627550 100644
> > > --- a/bitbake/lib/bb/server/xmlrpc.py
> > > +++ b/bitbake/lib/bb/server/xmlrpc.py
> > > @@ -193,6 +193,8 @@ class XMLRPCServer(SimpleXMLRPCServer,
> > > BaseImplServer):
> > >          BaseImplServer.__init__(self)
> > >          if (interface[1] == 0):     # anonymous port, not getting
> > > reused
> > >              self.single_use = True
> > > +        else:
> > > +            self.singe_use = False
> > 
> > This won't work, right? Typo.
> > 
> > Regards,
> > 
> > Joshua
> 
> Or you can simplify it as:
> 
>             self.single_use = interface[1] == 0

I thought about doing this. Decided not to do as it's less readable from
my point of view.

--
Regards,
Ed