[bitbake-devel] [RFC master][PATCH 4/4] bitbake-layers: convert to plugin-based

[Paul Eggleton]

On Thu, 12 May 2016 16:22:15 Christopher Larson wrote:
> On Thu, May 12, 2016 at 4:20 PM, Richard Purdie <
> 
> richard.purdie at linuxfoundation.org> wrote:
> > On Thu, 2016-05-12 at 16:12 -0700, Christopher Larson wrote:
> > > On Sat, Apr 30, 2016 at 12:41 PM, Christopher Larson <
> > > 
> > > kergoth at gmail.com> wrote:
> > > > From: Christopher Larson <chris_larson at mentor.com>
> > > > 
> > > > This uses bb.utils.load_plugins, based on the plugin handling in
> > > > recipetool
> > > > and devtool in oe-core.
> > > > 
> > > > Signed-off-by: Christopher Larson <chris_larson at mentor.com>
> > > > ---
> > > > 
> > > >  bin/bitbake-layers                 | 1065 ++----------------------
> > > > 
> > > > ------------
> > > > 
> > > >  bitbake/lib/bblayers/__init__.py   |    2 +
> > > >  bitbake/lib/bblayers/action.py     |  233 ++++++++
> > > >  bitbake/lib/bblayers/common.py     |   33 ++
> > > >  bitbake/lib/bblayers/layerindex.py |  270 +++++++++
> > > >  bitbake/lib/bblayers/query.py      |  499 +++++++++++++++++
> > > >  6 files changed, 1097 insertions(+), 1005 deletions(-)
> > > >  create mode 100644 bitbake/lib/bblayers/__init__.py
> > > >  create mode 100644 bitbake/lib/bblayers/action.py
> > > >  create mode 100644 bitbake/lib/bblayers/common.py
> > > >  create mode 100644 bitbake/lib/bblayers/layerindex.py
> > > >  create mode 100644 bitbake/lib/bblayers/query.py
> > > 
> > > Was this patch not applied for a specific reason, or just needs more
> > > time for review, or waiting until after python3 is merged?
> > 
> > The other pieces were straightforward so I merged them. I meant to ask
> > Paul for an Acked-by on this piece as he'd done more work on the plugin
> > based tools than I have but then I got distracted, sorry. Paul is
> > cc'd...
> 
> Not a problem, just wanted to make sure it didn't slip through the cracks :)

This looks pretty good to me - I like how you've put in a proper object 
structure as well which is nicer than the flat functions used in 
devtool/recipetool plugins.

Acked-by: Paul Eggleton <paul.eggleton at linux.intel.com>

Cheers,
Paul

-- 
Paul Eggleton
Intel Open Source Technology Centre