[bitbake-devel] [RFC master][PATCH 4/4] bitbake-layers: convert to plugin-based

[Richard Purdie]

On Mon, 2016-05-16 at 23:06 +0100, Richard Purdie wrote:
> On Sat, 2016-04-30 at 12:41 -0700, Christopher Larson wrote:
> > From: Christopher Larson <chris_larson at mentor.com>
> > 
> > This uses bb.utils.load_plugins, based on the plugin handling in
> > recipetool
> > and devtool in oe-core.
> > 
> > Signed-off-by: Christopher Larson <chris_larson at mentor.com>
> > ---
> >  bin/bitbake-layers                 | 1065 ++----------------------
> > --
> > ----------
> >  bitbake/lib/bblayers/__init__.py   |    2 +
> >  bitbake/lib/bblayers/action.py     |  233 ++++++++
> >  bitbake/lib/bblayers/common.py     |   33 ++
> >  bitbake/lib/bblayers/layerindex.py |  270 +++++++++
> >  bitbake/lib/bblayers/query.py      |  499 +++++++++++++++++
> 
> Sorry, one other question. Did you mean to create a bitbake/lib
> within
> the bitbake repo or should this just be lib/ ? I'm guessing the
> latter
> and have queued it in -next with that.

The regression tests also found one small problem:

oe-selftest --run-tests bblayers.BitbakeLayers.test_bitbakelayers_showrecipes

======================================================================
FAIL: test_bitbakelayers_showrecipes (oeqa.selftest.bblayers.BitbakeLayers)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/media/build1/poky/meta/lib/oeqa/utils/decorators.py", line 109, in wrapped_f
    return func(*args, **kwargs)
  File "/media/build1/poky/meta/lib/oeqa/selftest/bblayers.py", line 92, in test_bitbakelayers_showrecipes
    self.assertNotEqual(result.status, 0, 'bitbake-layers show-recipes -i nonexistentclass should have failed')
AssertionError: 0 == 0 : bitbake-layers show-recipes -i nonexistentclass

$ bitbake-layers show-recipes -i nonexistentclass
Parsing recipes..done.
ERROR: No class named classes/nonexistentclass.bbclass found in BBPATH
$ echo $?
0

I've tweaked the patch to change the "return 1" to a sys.exit(1) since
I'd prefer to get this patch in to avoid more rebasing with the python3
branch.

Cheers,

Richard