[bitbake-devel] [PATCH] data_smart.py: don't reorder internal bitbake variables when calculating hash

Patrick Ohly patrick.ohly at intel.com
Mon Nov 14 09:39:00 UTC 2016


Commit 260ced745 added __BBTASKS, __BBANONFUNCS, __BBHANDLERS to the
data that gets hashed, but only after reordering these lists. The
intention probably was to make the hash deterministic, but that's
unnecessary (the content of the variables should already be
deterministic) and hides potential reasons that might require
re-parsing.

Signed-off-by: Patrick Ohly <patrick.ohly at intel.com>
---
 lib/bb/data_smart.py | 1 -
 1 file changed, 1 deletion(-)

diff --git a/lib/bb/data_smart.py b/lib/bb/data_smart.py
index f100446..b35ee9b 100644
--- a/lib/bb/data_smart.py
+++ b/lib/bb/data_smart.py
@@ -956,7 +956,6 @@ class DataSmart(MutableMapping):
 
         for key in ["__BBTASKS", "__BBANONFUNCS", "__BBHANDLERS"]:
             bb_list = d.getVar(key, False) or []
-            bb_list.sort()
             data.update({key:str(bb_list)})
 
             if key == "__BBANONFUNCS":
-- 
2.1.4




More information about the bitbake-devel mailing list