[bitbake-devel] [PATCH] bb.runqueue: fix unexpected process death logic

[Christopher Larson]

On Thu, Oct 6, 2016 at 9:07 PM, Christopher Larson <kergoth at gmail.com>
wrote:

> From: Christopher Larson <chris_larson at mentor.com>
>
> `if w in self.rq.worker` when w *is* self.rq.worker doesn't make a great
> deal
> of sense, and results in this error:
>
>       File ".../poky/bitbake/lib/bb/runqueue.py", line 2372, in
> runQueuePipe.read():
>                              name = None
>         >                    if w in self.rq.worker:
>                                  name = "Worker"
>     TypeError: unhashable type: 'dict'
>
> Most likely this was meant to be 'is' rather than 'in', but rather than
> checking after the fact, just include the name in the iteration, instead.
>
> While we're here, also clean up and fix the broken error message.
>
> Signed-off-by: Christopher Larson <chris_larson at mentor.com>
>

Ah, no, it wasn’t meant to be is, clearly this was a missed w -> w[mc]
replacement, so it was meant to be in, just with a different value. Still
worth simplifying that handling a bit, regardless :)
-- 
Christopher Larson
kergoth at gmail dot com
Founder - BitBake, OpenEmbedded, OpenZaurus
Maintainer - Tslib
Senior Software Engineer, Mentor Graphics
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openembedded.org/pipermail/bitbake-devel/attachments/20161006/90b9886b/attachment-0002.html>