[bitbake-devel] [PATCH] codeparser: Use hashlib for hashing, not hash()

[Christopher Larson]

On Wed, Sep 28, 2016 at 8:25 AM, akuster <akuster at mvista.com> wrote:

> On 09/28/2016 08:14 AM, Richard Purdie wrote:
>
>> On Wed, 2016-09-28 at 08:06 -0700, Armin Kuster wrote:
>>
>>> From: Richard Purdie <richard.purdie at linuxfoundation.org>
>>>
>>> "hash() is randomised by default each time you start a new instance
>>> of
>>> recent
>>> versions (Python3.3+) to prevent dictionary insertion DOS attacks"
>>>
>>> which means we need to use hashlib.md5 to get consistent values for
>>> the codeparser cache under python 3. Prior to this, the codeparser
>>> cache was effectively useless under python3 as shown by performance
>>> regressions.
>>>
>>> Signed-off-by: Richard Purdie <richard.purdie at linuxfoundation.org>
>>> (cherry picked from commit 12d43cf45ba48e3587392f15315d92a1a53482ef)
>>>
>>> We kept running into an issue where shell scripts were not
>>> getting generated on 32bit hosts. It seemed to be caused by this
>>> code.
>>>
>> I'm puzzled. This patch is in master. I'm therefore assuming you're
>> suggesting this for 1.30 but it doesn't say that anywhere.
>>
>
> We made a similar change in our bitbake sources for 1.28 which needed to
> be submitted per the Yocto compatible requirements.   I could have sent
> that one but then you might have said "Hey, this looks like the one in
> Master, why are you not using that one?".   I personally like to reference
> upstream official fixes than hand crafted ones that achieve the same
> result. I can send you the one we did if you want.


I think the problem is you didn’t actually say what version/branch you
wanted it applied to, not which commit the patch references..
-- 
Christopher Larson
clarson at kergoth dot com
Founder - BitBake, OpenEmbedded, OpenZaurus
Maintainer - Tslib
Senior Software Engineer, Mentor Graphics
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openembedded.org/pipermail/bitbake-devel/attachments/20160928/cc879ee6/attachment-0002.html>