[bitbake-devel] [PATCH V2 2/6] toaster: update Toaster for Django 1.11

Reyna, David david.reyna at windriver.com
Fri Dec 22 06:32:14 UTC 2017


Hi Richard,

> Somehow there is a "V2" in the patch that caused it to fail to apply.

Ouch. 

Not only that, somehow that same "V2" glitch ruined my "PATCH V2 2/6" file, which breaks Toaster on startup for master. I will send a fix-up patch.

Those errors are not in the parallel patch set that was for "rocko", so at least that was not ruined.

- David

-----Original Message-----
From: Richard Purdie [mailto:richard.purdie at linuxfoundation.org] 
Sent: Monday, December 18, 2017 7:08 AM
To: Reyna, David; bitbake-devel at lists.openembedded.org
Subject: Re: [bitbake-devel] [PATCH V2 2/6] toaster: update Toaster for Django 1.11

On Thu, 2017-11-30 at 00:55 -0800, David Reyna wrote:
> --- a/lib/toaster/toastergui/views.py
> +++ b/lib/toaster/toastergui/views.py
> @@ -277,7 +277,7 @@ def _validate_input(field_input, model):
>              return None, invalid + str(field_input_list)
>  
>          V2 # Check we are looking for a valid field
> -        valid_fields = model._meta.get_all_field_names()
> +        valid_fields = [f.name for f in model._meta.get_fields()]
>          for field in field_input_list[0].split(AND_VALUE_SEPARATOR):
>              if True in [field.startswith(x) for x in valid_fields]:
>                  break

Sorry about the delay with these. Somehow there is a "V2" in the patch that caused it to fail to apply. I've fixed that up manually and applied it.

Cheers,

Richard


More information about the bitbake-devel mailing list