[bitbake-devel] [PATCH] runqueue: Fix collapsed setscene dependency tree

[Peter Kjellerstedt]

> -----Original Message-----
> From: bitbake-devel-bounces at lists.openembedded.org [mailto:bitbake-
> devel-bounces at lists.openembedded.org] On Behalf Of Richard Purdie
> Sent: den 19 februari 2017 15:16
> To: bitbake-devel at lists.openembedded.org
> Subject: [bitbake-devel] [PATCH] runqueue: Fix collapsed setscene
> dependency tree
> 
> When we removed the postinst sstate dependency handling code from
> setscene_depvalid, we noticed things being installed into the old
> style sysroot for rootfs tasks which should not have been there,
> causing a performance regression.
> 
> Analysis revealed that setscene dependencies were "bubbling" over
> sstate tasks when they should have been stopping there. The
> 'continue' added by this patch avoids this issue and eusures

Change "eusures" to "ensures".

> sstate tasks remain contained to their specific chains.
> 
> There was another bug in the code this exposed where the acconting

Change "acconting" to "accounting".

> for tasks as they were removed from sq_revdeps was not correct. In
> fixing this, what looks like a workaround in another test can then
> be simplified.
> 
> After this change, populate_sysroot tasks are no longer depending
> on package_write_rpm tasks for example, which would make no sense.
> 
> A before/after analysis of image dependencies only revealed improved
> dependencies after this change.
> 
> Recipe specific sysroots did highlight the issue here since the
> behaviour of the sysroot dependencies (and processing with depvalid)
> was not matching what bitbake itself was doing, with bitbake being
> incorrect. Failures were 'safe' in that too many dependencies would
> get installed.
> 
> Signed-off-by: Richard Purdie <richard.purdie at linuxfoundation.org>

//Peter