[bitbake-devel] [PATCH] cooker: Drop package-depends.dot and pn-depends.dot generation

[Richard Purdie]

On Wed, 2017-01-25 at 11:05 +0000, Peter Kjellerstedt wrote:
> > 
> > -----Original Message-----
> > From: bitbake-devel-bounces at lists.openembedded.org [mailto:bitbake-
> > devel-bounces at lists.openembedded.org] On Behalf Of Richard Purdie
> > Sent: den 23 januari 2017 23:38
> > To: bitbake-devel at lists.openembedded.org
> > Subject: [bitbake-devel] [PATCH] cooker: Drop package-depends.dot
> > and
> > pn-depends.dot generation
> > 
> > A long time ago when we switched to task basked execution we added
> > task-depends.dot and generated package-depends.dot and pn-
> > depends.dot
> > for compatibility as best we could.	
> > 
> > The problem is they contain partial data about the taskgraph, its
> > incomplete and tends to confuse users.
> > 
> > I propose we remove the two compatibilty outputs and just generate
> > the one which contains definitive data.
> > 
> > Signed-off-by: Richard Purdie <richard.purdie at linuxfoundation.org>
> Is there any alternative to removing package-depends.dot and 
> especially pn-depends.dot?

We don't have to remove them but what worries me is that the data in
them is incomplete. Its some subset of what the real task graph looks
like and at some point someone is going to complain the data was
inaccurate/misleading (which it is).

>  The reason I ask is because we use 
> pn-dependes.dot when visualizing the dependencies between packages. 
> Even though task-depends.dot is more complete, trying to render it 
> is near impossible given the sheer number of nodes and edges it 
> contains. Already visualizing pn-depends.dot is hard but possible 
> with some gvpr and tred filtering. Here are some statistics from 
> one of my typical builds:
> 
>                         Nodes  Edges
>                         -----  ------
> pn-depends.dot           1183   12087
> package-depends.dot      5939   55615
> task-depends.dot        13756  125870
> 
> As can be seen, the number of nodes and edges in task-depends.dot 
> is a magnitude greater than in pn-depends.dot.

Its certainly simpler, but the data is just plain buggy. I'm not sure
I'd trust anything those files told me, even if they are easier to
view.

I appreciate task-depends is hard to load graphically, it is helpful
even as a text file though, I do use it a lot since its a near direct
dump of bitbake's internal parsed task dependencies.

Cheers,

Richard