[bitbake-devel] [PATCH] fetch2/gitsm: Fix when repository change submodules

[Christopher Larson]

On Mon, Jul 24, 2017 at 2:43 PM, Christopher Larson <kergoth at gmail.com>
wrote:

> On Wed, Feb 3, 2016 at 9:29 AM, Felipe F. Tonello <eu at felipetonello.com>
> wrote:
>
>> This fix a problem when checking out a commit that changes the submodules
>> previously checkout.
>>
>> Example:
>> Recipe uses branch A and then it updates to use branch B, but branch B has
>> different submodules dependencies then what branch A previously had.
>>
>> Signed-off-by: Felipe F. Tonello <eu at felipetonello.com>
>>
>
> This completely broke the gitsm fetcher behavior. It no longer uses the
> previously fetched submodules from DL_DIR at all, instead the submodule
> update is re-cloning them from upstream in do_unpack, violating our
> conventions. Git checkout isn’t going to magically copy the existing
> fetched submodules from DL_DIR.
>

Apologies for the harsh tone here, but clearly we should fix this
differently. https://bugzilla.yoctoproject.org/show_bug.cgi?id=11830 has
been opened for this. It’ll be difficult to add a good unit test to catch
this problem without using either a VM or containers to physically cut
network connectivity. I’m going to propose a future bitbake enhancement to
use namespaces to prevent network connectivity from non-fetch tasks.
-- 
Christopher Larson
kergoth at gmail dot com
Founder - BitBake, OpenEmbedded, OpenZaurus
Senior Software Engineer, Mentor Graphics
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openembedded.org/pipermail/bitbake-devel/attachments/20170724/9b97984f/attachment-0002.html>