[bitbake-devel] [PATCH] fetch2: fix checkstatus fallback to MIRRORS

Ross Burton ross.burton at intel.com
Fri Jul 28 16:26:23 UTC 2017


The checkstatus() code was expecting checkstatus to throw exceptions if it
failed, but in general it should return False.

Signed-off-by: Ross Burton <ross.burton at intel.com>
---
 bitbake/lib/bb/fetch2/__init__.py | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/bitbake/lib/bb/fetch2/__init__.py b/bitbake/lib/bb/fetch2/__init__.py
index bd23533ebc0..7afb2aeb734 100644
--- a/bitbake/lib/bb/fetch2/__init__.py
+++ b/bitbake/lib/bb/fetch2/__init__.py
@@ -1726,9 +1726,8 @@ class Fetch(object):
             ret = try_mirrors(self, self.d, ud, mirrors, True)
             if not ret:
                 # Next try checking from the original uri, u
-                try:
-                    ret = m.checkstatus(self, ud, self.d)
-                except:
+                ret = m.checkstatus(self, ud, self.d)
+                if not ret:
                     # Finally, try checking uri, u, from MIRRORS
                     mirrors = mirror_from_string(self.d.getVar('MIRRORS'))
                     ret = try_mirrors(self, self.d, ud, mirrors, True)
-- 
2.11.0




More information about the bitbake-devel mailing list