[bitbake-devel] [PATCHv2] bitbake-layers: check layer dependencies before adding

[Chang, Rebecca Swee Fun]

Hi Richard,

Thanks! We have found out why it failed.
We were using "-f" to force add a layer without going through recipe parse.
I just realized the bitbake selftests were using "-f" in bitbake-layers show-recipes.
The argument flags were overriding each other.
I will fix that in v3 patch.

Regards,
Rebecca

> -----Original Message-----
> From: Richard Purdie [mailto:richard.purdie at linuxfoundation.org]
> Sent: Sunday, June 4, 2017 10:13 PM
> To: Chang, Rebecca Swee Fun <rebecca.swee.fun.chang at intel.com>; Bitbake
> dev Mailing List <bitbake-devel at lists.openembedded.org>
> Cc: Phoong, Stanley Cheong Kwan <stanley.cheong.kwan.phoong at intel.com>
> Subject: Re: [bitbake-devel] [PATCHv2] bitbake-layers: check layer
> dependencies before adding
> 
> On Mon, 2017-05-29 at 08:44 +0800, Chang Rebecca Swee Fun wrote:
> > In the original implementation, "bitbake-layers add-layers <layer>"
> > succeeded without error checking. This will further introduce failures
> > in recipe parsing only when "bitbake" command is executed.
> > Adding a meta layer without its dependency layer(s) should failed and
> > exit the process gracefully.
> >
> > Added extra argument "-f" to force add a layer without checking layer
> > dependency.
> >
> > [YOCTO #10913]
> >
> > Signed-off-by: Phoong Stanley Cheong Kwan <stanley.cheong.kwan.phoong
> > @intel.com>
> > Signed-off-by: Chang Rebecca Swee Fun <rebecca.swee.fun.chang at intel.c
> > om>
> > ---
> >  bin/bitbake-layers     |  1 +
> >  lib/bblayers/action.py | 26 ++++++++++++++++++++++----
> >  2 files changed, 23 insertions(+), 4 deletions(-)
> 
> This patch seems to result in this:
> 
> https://autobuilder.yocto.io/builders/nightly-oe-
> selftest/builds/320/steps/Running%20oe-selftest/logs/stdio
> 
> Cheers,
> 
> Richard