[bitbake-devel] [PATCH 1/1] bitbake:process: flush stderr/stdout to log

[Bystricky, Juro]

Thanks, good catch. There are various log flushes already there, so the "final" flush
not being executed went undetected in testing, may not even be needed any more.
I am surprised I did not get any python warnings though.

________________________________
From: Christopher Larson [kergoth at gmail.com]
Sent: Tuesday, June 13, 2017 8:46 AM
To: Bystricky, Juro
Cc: bitbake-devel at lists.openembedded.org; Purdie, Richard; Juro Bystricky; paul.eggleton at linux.intel.com
Subject: Re: [bitbake-devel] [PATCH 1/1] bitbake:process: flush stderr/stdout to log


On Mon, Jun 12, 2017 at 10:12 AM, Juro Bystricky <juro.bystricky at intel.com<mailto:juro.bystricky at intel.com>> wrote:
-    finally:
-        log.flush()
-
-    readextras([fobj for fobj, _ in extrafiles])
+            read_all_pipes(log, rin, outdata, errdata)
+
+        # Pocess closed, drain all pipes...
+        read_all_pipes(log, rin, outdata, errdata)
+    finally:
+        log.flush

You forgot a (), so you aren’t actually running flush here.
--
Christopher Larson
kergoth at gmail dot com
Founder - BitBake, OpenEmbedded, OpenZaurus
Senior Software Engineer, Mentor Graphics
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openembedded.org/pipermail/bitbake-devel/attachments/20170613/ff813c89/attachment-0002.html>