[bitbake-devel] [PATCH 1/2] utils/md5_file: don't iterate line-by-line

[Richard Purdie]

On Tue, 2018-08-14 at 10:33 +0200, Rasmus Villemoes wrote:
> On 2018-08-13 20:02, Ross Burton wrote:
> > Opening a file in binary mode and iterating it seems like the
> > simple solution
> > but will still break on newlines, which for binary files isn't
> > really useful as
> > the size of the chunks could be huge or tiny.
> 
> And what exactly was wrong with
> 
> http://lists.openembedded.org/pipermail/bitbake-devel/2018-July/00940
> 7.html
> http://lists.openembedded.org/pipermail/bitbake-devel/2018-July/00940
> 9.html
> 
> ? I have lots of patches and ideas for performance improvements in
> bitbake, pseudo and other components, but I'm not getting any
> response
> at all, which is rather frustrating.

Sorry, that is my fault, I hadn't gotten around to reviewing/testing
them.

Ross' patch using mmap should be slightly more efficient so I'll likely
go with that but I'd take a patch to sort the other hash functions
(e.g. sha256) out similarly and now I'm much more familiar with the
code and expecting the change, review should be much simpler/faster...

Sorry once again...

Cheers,

Richard