[bitbake-devel] [PATCH] Add a variable to pass flags to fakeroot (pseudo)

[richard.purdie at linuxfoundation.org]

On Thu, 2018-12-06 at 21:27 -0600, Joshua Watt wrote:
> On Thu, Dec 6, 2018 at 4:05 PM Richard Purdie
> <richard.purdie at linuxfoundation.org> wrote:
> > On Thu, 2018-12-06 at 12:55 -0600, Joshua Watt wrote:
> > > It is occasionally useful to pass additional flags to fakeroot
> > > (pseudo)
> > > either for debugging or for behavioral system changes. Add a
> > > variable
> > > called "FAKEROOTARGS" that can be used for this purpose.
> > 
> > Why wouldn't you just append to FAKEROOT/FAKEROOTCMD ?
> 
> You can't currently add arguments to FAKEROOTCMD because it is passed
> as an array member to subprocess.Popen sort of like:
> 
>  subprocess.Popen([d.getVar('FAKEROOTCMD'), 'blah', 'blah', ...
> 
> In order to pass arguments, it would probably have to have split into
> an array i.e. :
> 
>  subprocess.Popen(d.getVar('FAKEROOTCMD').split() + ['blah', 'blah',
> ...
> 
> I wasn't sure if that was desirable or if it would break anything, so
> I went with the lower risk approach of adding a new variables. I can
> certainly make a change to modify the usage of FAKEROOTCMD as
> described above and simply append the flags to it if that is
> preferred.

I'd prefer to fix this to work than add more variables...

Cheers,

Richard