[bitbake-devel] [PATCH 2/3] data_smart: Allow numeric characters in overrides

[richard.purdie at linuxfoundation.org]

On Wed, 2018-12-19 at 10:55 +0000, Peter Kjellerstedt wrote:
> I don't understand the commit message either. It says that there are 
> problems with x86-64 because it contains digits, but x86 (which the 
> commit message says works) contains digits too, so that cannot
> really 
> be the case. If it is actually the dash in x86-64 that is supposedly 
> a cause of problems, then islower() ignores both digits and non-
> alpha 
> characters like the dash so that cannot really be a reason to change 
> the code either. All in all I'm confused by this commit and what it 
> is trying to solve...

Consider this output from python:

>>> "64".islower()
False
>>> "x64".islower()
True
>>> "x64A".islower()
False
>>> 

The problem is that "64".islower() returns False when we need True
(overrides get split by '_' so x86_64 turns into "x86" and "64" in the
code in question).

Cheers,

Richard