[bitbake-devel] [PATCH 4/4] runqueue: Rewrite and optimize recrdepends handling

[Paul Barker]

On Mon, Feb 26, 2018 at 4:55 PM, Paul Barker <pbarker at toganlabs.com> wrote:
> On Mon, Feb 26, 2018 at 4:53 PM, Richard Purdie
> <richard.purdie at linuxfoundation.org> wrote:
>>
>> Thanks, more information helped. I think you have found a bug. I'm
>> wondering about:
>>
>> diff --git a/bitbake/lib/bb/runqueue.py b/bitbake/lib/bb/runqueue.py
>> index 48df0131556..f2e52cf758c 100644
>> --- a/bitbake/lib/bb/runqueue.py
>> +++ b/bitbake/lib/bb/runqueue.py
>> @@ -765,7 +765,7 @@ class RunQueueData:
>>              bb.debug(1, "Added %s recursive dependencies in this loop" % extradeps)
>>
>>          # Remove recrdeptask circular references so that do_a[recrdeptask] = "do_a do_b" can work
>> -        for tid in self.runtaskentries:
>> +        for tid in recursivetasksselfref:
>>              self.runtaskentries[tid].depends.difference_update(recursivetasksselfref)
>>
>>          self.init_progress_reporter.next_stage()
>>
>> as a fix for it...
>>
>
> That makes sense. I'll apply that change and see if it works.
>

That's working for me. Dependencies are all resolved correctly and I'm
not seeing any errors.

-- 
Paul Barker
Togán Labs Ltd