[bitbake-devel] [PATCH 0/9] Always use the url specified in the recipe as a base for the git shallow tarball naming

[Richard Purdie]

On Mon, 2018-07-23 at 17:42 +0200, Urs Fässler wrote:
> The existing behavior was to use the url where the repository was
> cloned from.
> It happened that the tarball was not found when a mirror rewrite rule
> was active.
> 
> We now use the url specified in the recipe to name the shallow
> tarball. It fixes that the tarball is not found under certain
> conditions. In addition, the naming is independent of network/server
> failure and the mapping of the name is easier to understand.

I'm not sure why but throughout this patch series you've used function
names and variables prefixed with "__". We don't do this with any of
our other code so it seems out of keeping with the rest of the coding
style.

With regard to the function "__has_up_to_date_clonedir" you added, its
very unclear why some checks would go in that function and some checks
would go in the other. The commit description helps understand it a bit
more but that doesn't help the function naming or someone looking at
the code in future.

Finally, I'm still not convinced that passing around the original url
and forcing the original url naming into any mirroring code is the
right solution to the problem. I said that at the start and looking at
this code change, I'm still not convinced this is right. Part of the
reason I continue to believe that is you just added a N*N testing
problem to the fetcher where the fetchers now behave differently
depending on two urls passed in rather than just one :(.

Cheers,

Richard