[bitbake-devel] [PULL] *** Fix build issue with html5lib in bitbake 1.26/1.28 ***

[Soemoe Aung]

Just saw that Richard Purdie backported Daniel Lublin's original commit to
1.26 and 1.28 (edd90cd858da5da564e9849ebc0849a8a8173d4f
<http://git.openembedded.org/bitbake/commit/?h=1.26&id=edd90cd858da5da564e9849ebc0849a8a8173d4f>
and 0d80cacb2b84ee059cee3caf8a5968033b9ce3c5
<http://git.openembedded.org/bitbake/commit/?h=1.28&id=0d80cacb2b84ee059cee3caf8a5968033b9ce3c5>).
I noticed it was pushed upstream to yocto-poky fido and jethro as well. I
did a fresh checkout of yocto-poky fido and jethro and got both to build
past that error out of the box. Thanks to Richard and Daniel and everyone
else!

On Thu, Mar 29, 2018 at 10:43 AM, Peter Kjellerstedt <
peter.kjellerstedt at axis.com> wrote:

> One way to create and send the patch is:
>
>
>
> git cherry-pick 1679188f9c55c615cae780f2b5e6852dea9cf2ec # Assuming you
> are in the bitbake repository, not poky
>
> git commit --amend  # To add your Signed-off-by footer
>
> git format-patch --subject-prefix='jethro][PATCH' 'HEAD^..HEAD'
>
> git send-email --to=openembedded-core at lists.openembedded.org
> --confirm=always --no-chain-reply-to --suppress-cc=all 000*
>
>
>
> //Peter
>
>
>
> *From:* bitbake-devel-bounces at lists.openembedded.org [mailto:
> bitbake-devel-bounces at lists.openembedded.org] *On Behalf Of *Soemoe Aung
> *Sent:* den 28 mars 2018 18:47
> *To:* Ola x Nilsson <Ola.x.Nilsson at axis.com>
> *Cc:* bitbake-devel at lists.openembedded.org
> *Subject:* Re: [bitbake-devel] [PULL] *** Fix build issue with html5lib
> in bitbake 1.26/1.28 ***
>
>
>
> Yes, that's essentially what I'm asking for. Sorry if that wasn't clear.
> That fix is in bitbake 1.30 but seems to be needed in 1.26 and 1.28 as
> well. My change literally took the html5lib file from 1.30 and copied it to
> the file in 1.26 and submitted it as a patch. Apologies if this was the
> wrong way to go about this.
>
>
>
> What are the steps to backport this change to 1.26 and 1.28 (and also to
> send these changes upstream to yocto-poky)? Is there anything I need to do?
>
>
>
> On Wed, Mar 28, 2018 at 2:41 AM, Ola x Nilsson <ola.x.nilsson at axis.com>
> wrote:
>
> This has already been fixed on a few branches with
>
> bitbake: lib/bs4: Fix imports from html5lib >= 0.9999999/1.0b8
>
> It might be better to backport that where needed.
>
> --
> Ola Nilsson
> ________________________________________
> From: bitbake-devel-bounces at lists.openembedded.org <
> bitbake-devel-bounces at lists.openembedded.org> on behalf of Soemoe Aung <
> soemoe.a at gmail.com>
> Sent: Tuesday, March 27, 2018 23:15
> To: bitbake-devel at lists.openembedded.org
> Subject: [bitbake-devel] [PULL] *** Fix build issue with html5lib in
> bitbake    1.26/1.28 ***
>
>
> When I was running yocto-poky on the fido and jethro branches, I was
> getting build errors caused by the included html5lib in bitbake. It seems
> like a class is being called incorrectly there. I noticed the issue is
> resolved in the krogoth branch and the html5lib is indeed different there.
>
> yocto-poky fido includes bitbake version 1.26 and jethro includes bitbake
> version 1.28. Looking at the bitbake source repo for these versions
> confirms that these files are the same. yocto-poky krogoth, which has the
> issue fixed, uses bitbake 1.30, which also has the issue fixed in the
> bitbake repo.
>
> I originally created this patch in the yocto-poky contrib repo and was
> directed to send it to bitbake instead. Can someone here take a look at
> this and accept the changes into the 1.26 and 1.28 branches? Can you also
> send these changes upstream to the yocto-poky fido and jethro branches?
>
> Let me know if you need any changes here, like creating this patch from
> the bitbake repo directly instead of indirectly through yocto-poky.
>
> The following changes since commit ea6d21066a7cce2fef08ad66287170
> c5995bb1e2:
>
>   bitbake: bitbake-user-manual: Fixed porno hack for hello world example
> (2018-01-17 22:32:46 +0000)
>
> are available in the Git repository at:
>
>   git://push.yoctoproject.org/poky-contrib saung/bitbake-html5lib
>
> Soemoe Aung (2):
>   fix build error in included html5lib in bitbake
>   fix html5lib fix to be the same as in the krogoth branch
>
>  bitbake/lib/bs4/builder/_html5lib.py | 17 ++++++++++++-----
>  1 file changed, 12 insertions(+), 5 deletions(-)
>
> --
> 2.17.0.rc0.231.g781580f067-goog
>
> --
> _______________________________________________
> bitbake-devel mailing list
> bitbake-devel at lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/bitbake-devel
> --
> _______________________________________________
> bitbake-devel mailing list
> bitbake-devel at lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/bitbake-devel
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openembedded.org/pipermail/bitbake-devel/attachments/20180330/a6f51406/attachment-0002.html>