[bitbake-devel] git submodule fetcher regression

[Stefan Agner]

Hi Mark,

On 04.10.2018 20:51, Ricardo Salveti wrote:
> On Thu, Oct 4, 2018 at 1:47 PM Mark Hatle <mark.hatle at windriver.com> wrote:
>>
>> On 10/4/18 11:08 AM, Stefan Agner wrote:
>> > [resend, this time with me being subscriber of bitbake-devel]
>> >
>> > Hi,
>> >
>> > It seems that 9c6b39adf978 ("fetch2/gitsm.py: Rework the git submodule fetcher") broke git submodules in some cases. My particular case is aktualizr from meta-updater (https://github.com/advancedtelematic/meta-updater). Fetching aktualizr reliably fails for me now:
>> >
>> > ERROR: aktualizr-1.0+gitAUTOINC+a94a15e31f-7 do_unpack: Fetcher failure: Submodule tests/tuf-test-vectors does not exist in /home/ags/oe/downloads/git2/github.com.advancedtelematic.aktualizr/modules/tests/tuf-test-vectors or
>> > /home/ags/oe/build-colibri-imx7/tmp-oe/work/armv7at2hf-neon-lmp-linux-gnueabi/aktualizr/1.0+gitAUTOINC+a94a15e31f-7/git/.git/modules/tests/tuf-test-vectors.
>> > ERROR: aktualizr-1.0+gitAUTOINC+a94a15e31f-7 do_unpack: Function failed: base_do_unpack
>> > ERROR: Logfile of failure stored in: /home/ags/oe/build-colibri-imx7/tmp-oe/work/armv7at2hf-neon-lmp-linux-gnueabi/aktualizr/1.0+gitAUTOINC+a94a15e31f-7/temp/log.do_unpack.35143
>> > ERROR: Task (/home/ags/oe/build-colibri-imx7/conf/../../layers/meta-updater/recipes-sota/aktualizr/aktualizr_git.bb:do_unpack) failed with exit code '1'
>> >
>> > Any idea what that could be?
>>
>> See the mailing list archives (or master-next branch).  There are a small series
>> of pending patches.  Please try these.
>>
>> 3 from Laurent Bonnans
>> 1 from me
> 
> Tested with latest bitbake from master-next and latest aktualizr from
> meta-updater and it seems functional again, looks like the patches
> from Laurent are already enough (up to the checkout submodules
> recursively).
> 
> Trying a completely clean build now to see if there are any other regressions.
> 

Tried todays bitbake master, which is fd9893c338df ("gitsm: Allow relative URIs when fetching"), containing the four commits mentioned above.

On my setup, building aktualizr, this fails to fetch source ref a94a15e31f3b973966b1afc9081fc1b17a3b9d48, while it works for a newer ref 512ad74c0b5339ca7775d8c9461b565a9e6ff5b3 (which presumably is what Ricardo tried).

This is a rather minimal recipe to reproduce the fetcher issue:

SUMMARY = "Aktualizr SOTA Client"
DESCRIPTION = "SOTA Client application written in C++"
HOMEPAGE = "https://github.com/advancedtelematic/aktualizr"
SECTION = "base"
LICENSE = "MPL-2.0"
LIC_FILES_CHKSUM = "file://${S}/LICENSE;md5=9741c346eef56131163e13b9db1241b3"

PV = "1.0+git${SRCPV}"
PR = "7"

SRC_URI = " \
  gitsm://github.com/advancedtelematic/aktualizr;branch=${BRANCH} \
  "
SRCREV = "a94a15e31f3b973966b1afc9081fc1b17a3b9d48"
BRANCH ?= "master"

S = "${WORKDIR}/git"

inherit cmake

--
Stefan