[bitbake-devel] [PATCH 2/7] data_smart: Micro optimise _remove handling

[richard.purdie at linuxfoundation.org]

On Fri, 2018-10-19 at 10:57 +0200, Martin Jansa wrote:
> This one and "data_smart: Fix expand_cache and _remove operator
> interaction issues" are slightly changing the behavior, not sure if
> this change was intended.

I think this is a bug, thanks for reporting. I was able to reprocduce
with OE-Core and a bbappend containing the line you mentioned. The way
RDEPENDS are handled in insane.bbclass is a little unique and I was
able to reduce it to a test case:

    def test_remove_with_override(self):
        self.d.setVar("TEST_bar", "testvalue2")
        self.d.setVar("TEST_some_val", "testvalue3 testvalue5")
        self.d.setVar("TEST_some_val_remove", "testvalue3")
        self.d.setVar("TEST_foo", "testvalue4")
        self.d.setVar("OVERRIDES", "foo:bar:some_val")
        self.assertEqual(self.d.getVar("TEST"), " testvalue5")

and this gives a good pointer to where/how the code is breaking. I'll
try and figure out how to fix it (and add a test case for it!).

Cheers,

Richard