[bitbake-devel] [PATCH 2/3] runqueue: Fix base class for sceneQueueComplete

[Tomasz Meresiński]

All runQueueEvents are for specific task - its __init__ function has 
task parameter and it reads more parameters from it (taskname, taskfile 
and taskhash).
sceneQueueComplete event is fired when all tasks are complete, so for me 
it isn't a runQueueEvent, so it isn't sceneQueueEvent too.
Passing None as task is not an option, because runQueueEvent.__init__ 
will fail.

On 29.10.2018 19:05, Christopher Larson wrote:
> This looks wrong. Fix the __init__ instead.
>
> On Mon, Oct 29, 2018 at 10:22 AM Tomasz Meresiński 
> <tomasz.meresinski at comarch.pl <mailto:tomasz.meresinski at comarch.pl>> 
> wrote:
>
>     __init__ method initialized bb.event.Event not sceneQueueEvent.
>     Change base class to bb.event.Event.
>
>     Signed-off-by: Tomasz Meresiński <tomasz.meresinski at comarch.com
>     <mailto:tomasz.meresinski at comarch.com>>
>     ---
>      lib/bb/runqueue.py | 2 +-
>      1 file changed, 1 insertion(+), 1 deletion(-)
>
>     diff --git a/lib/bb/runqueue.py b/lib/bb/runqueue.py
>     index 9ce06c40..e138a5c2 100644
>     --- a/lib/bb/runqueue.py
>     +++ b/lib/bb/runqueue.py
>     @@ -2615,7 +2615,7 @@ class sceneQueueTaskFailed(sceneQueueEvent):
>          def __str__(self):
>              return "Setscene task (%s) failed with exit code '%s' -
>     real task will be run instead" % (self.taskstring, self.exitcode)
>
>     -class sceneQueueComplete(sceneQueueEvent):
>     +class sceneQueueComplete(bb.event.Event):
>          """
>          Event when all the sceneQueue tasks are complete
>          """
>     -- 
>     2.17.1
>
>     -- 
>     _______________________________________________
>     bitbake-devel mailing list
>     bitbake-devel at lists.openembedded.org
>     <mailto:bitbake-devel at lists.openembedded.org>
>     http://lists.openembedded.org/mailman/listinfo/bitbake-devel
>
>
>
> -- 
> Christopher Larson
> kergoth at gmail dot com
> Founder - BitBake, OpenEmbedded, OpenZaurus
> Senior Software Engineer, Mentor Graphics

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openembedded.org/pipermail/bitbake-devel/attachments/20181029/b23514da/attachment-0002.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 4962 bytes
Desc: S/MIME Cryptographic Signature
URL: <http://lists.openembedded.org/pipermail/bitbake-devel/attachments/20181029/b23514da/attachment-0002.p7s>