[bitbake-devel] [sumo][PATCH] toaster: localhostbecontroller: fix bitbake path resolution

[Reyna, David]

Hi again,

I have submitted the patch. The patch itself looks the same to me, however I did use the official "create-pull-request" on top of the latest pull, so maybe it will have a happier apply. I also took advantage of this submission by adding a formal Bugzilla case number into the commit text.

- David

-----Original Message-----
From: bitbake-devel-bounces at lists.openembedded.org [mailto:bitbake-devel-bounces at lists.openembedded.org] On Behalf Of Reyna, David
Sent: Sunday, September 30, 2018 12:07 AM
To: akuster808; Belal, Awais; richard.purdie at linuxfoundation.org
Cc: bitbake-devel at lists.openembedded.org
Subject: Re: [bitbake-devel] [sumo][PATCH] toaster: localhostbecontroller: fix bitbake path resolution

Hi all,

I created my own version of Awais's patch from my Sumo branch. The only difference was that I based by patch from the "bitbake" directory (Awais did it from the bitbake/lib" directory), plus I got an extra blank line at the end.

I am going to submit my version of the patch in a few minutes. It should look identical to the original from Awais, except for the above observations.

- David

-----Original Message-----
From: akuster808 [mailto:akuster808 at gmail.com] 
Sent: Friday, September 28, 2018 9:09 AM
To: Belal, Awais; richard.purdie at linuxfoundation.org; Reyna, David; bitbake-devel at lists.openembedded.org
Subject: Re: [bitbake-devel] [sumo][PATCH] toaster: localhostbecontroller: fix bitbake path resolution



On 09/28/2018 03:38 AM, Belal, Awais wrote:
>>> The patch doesn't apply to master so could you send a version which
>>> applies there please?
>>> I can then apply the sumo one at the same time which does presumably
>>> apply to sumo (I've not tried that as yet).
> Extremely sorry, this is only needed for sumo (1.38), master doesn't have this problem.

This does not apply to sumo either. We have the commit it depends on:

c1f5ec8 bitbake: toaster: use a more flexible way to find bitbake

- armin

>
>
>
> BR,
> Awais
>
> ________________________________________
> From: richard.purdie at linuxfoundation.org <richard.purdie at linuxfoundation.org>
> Sent: Friday, September 28, 2018 12:52 PM
> To: Belal, Awais; Reyna, David; bitbake-devel at lists.openembedded.org
> Subject: Re: [bitbake-devel] [sumo][PATCH] toaster: localhostbecontroller: fix bitbake path resolution
>
> On Fri, 2018-09-28 at 07:37 +0000, Belal, Awais wrote:
>>>> I'm confused. Does master need the patch? or only sumo?
>> Both.
> The patch doesn't apply to master so could you send a version which
> applies there please?
>
> I can then apply the sumo one at the same time which does presumably
> apply to sumo (I've not tried that as yet).
>
> Thanks,
>
> Richard

-- 
_______________________________________________
bitbake-devel mailing list
bitbake-devel at lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/bitbake-devel