[bitbake-devel] [master][PATCH v2] fetch2/githubprivate: new fetcher for private github repositories

Ross Burton ross.burton at intel.com
Mon Dec 23 15:38:54 UTC 2019


On 20/12/2019 10:08, André Draszik wrote:
> -        elif self.type not in ["http", "https", "ftp", "ftps", "sftp", "s3"]:
> +        elif self.type not in ["http", "https", "ftp", "ftps", "githubprivate", "sftp", "s3"]:

I hate these lines.  I wonder if the fetcher class itself can have a 
md5_expected boolean field that can be used instead.

> +class Githubprivate(Wget):

It's too near Christmas to review this properly but that looks *a lot* 
neater!

Ross


More information about the bitbake-devel mailing list