[bitbake-devel] [PATCH] fetch2/svn: adds svn --ignore-externals option

[Mark Hatle]

I had a customer ask about this type of issue a few days ago as well.  I don't
know enough about SVN to comment directly on what should be default or not, just
that there is some type of an issue here, especially around svn:externals
pointing to bad external repositories and the need to pass --ignore-externals
for certain things.

On 2/16/19 1:36 AM, Krzysztof Zawadzki wrote:
> Hi,
> 
> I think so also. Subversion client is poor in exit statues when there are issues
> during svn:externals fetching. I have seen such issues previously. And it took a
> while to find there root cause (e.g switching revisions of svn:externals to non
> existing paths or revisions and some conflicts showed up).
> 
> @Richard Purdie
> It's better to create new patch which will add this option by default, with
> additional Docs update? Or update this one?

Do you have enough information to help create a reproducer case for this, so we
can add some additional fetcher test cases?

I know I needed to add a bunch of regression tests around the git submodule
fetcher to have any chance of preventing future regressions.

I suspect this may be a similar situation, we need more test cases.

--Mark

> Best Regards,
> Krzysztof Z.
> 
> sob., 16 lut 2019 o 00:00 Richard Purdie <richard.purdie at linuxfoundation.org
> <mailto:richard.purdie at linuxfoundation.org>> napisał(a):
> 
>     On Fri, 2019-02-15 at 04:25 +0100, Krzysztof Zawadzki wrote:
>     > With this option we can force users to provide all used sources in
>     > recipe.
>     > Without this there is possibility that repositories which are using
>     > svn:externals
>     >  can point to source code from HEAD or to nonexisting repository.
>     > This can cause attempt to reproduce build after some time impossible.
>     >
>     > Signed-off-by: Krzysztof Zawadzki <mr.k.zawadzki at gmail.com
>     <mailto:mr.k.zawadzki at gmail.com>>
>     > ---
>     >  lib/bb/fetch2/svn.py | 9 ++++++++-
>     >  1 file changed, 8 insertions(+), 1 deletion(-)
> 
>     I'm wondering if this should be the default and is something people
>     have to explicitly opt out of?
> 
>     Cheers,
> 
>     Richard
> 
>