[bitbake-devel] bitbake-devel Digest, Vol 99, Issue 4

[Ankur Tyagi]

Hi,

So should I only fix the path if protocol is http/https and send v2 of patch?

Thanks
Ankur

> Message: 1
> Date: Tue, 2 Jul 2019 10:19:46 +0000
> From: Ernst Sj?strand <ernst.sjostrand at verisure.com>
> To: "bitbake-devel at lists.openembedded.org"
>         <bitbake-devel at lists.openembedded.org>
> Subject: Re: [bitbake-devel] [bitbake-devel, 1.42, 1.40] git.py:
>         Handle space in git repo name
> Message-ID:
>         <d86c3787f5e287b397f96be56c8f680c5c16f564.camel at verisure.com>
> Content-Type: text/plain; charset="utf-8"
>
> Hi,
>
> wouldn't this break the non-http protocols?
>
> Regards
> //Ernst
>
> tis 2019-07-02 klockan 21:07 +1200 skrev Ankur Tyagi:
> > Signed-off-by: Ankur Tyagi <
> > ankur.tyagi85 at gmail.com
> > >
> > ---
> >  lib/bb/fetch2/git.py | 6 +++---
> >  1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/lib/bb/fetch2/git.py b/lib/bb/fetch2/git.py
> > index e171aa7e..5300fa8f 100644
> > --- a/lib/bb/fetch2/git.py
> > +++ b/lib/bb/fetch2/git.py
> > @@ -236,7 +236,7 @@ class Git(FetchMethod):
> >                      ud.unresolvedrev[name] = ud.revisions[name]
> >                  ud.revisions[name] = self.latest_revision(ud, d,
> > name)
> >
> > -        gitsrcname = '%s%s' % (ud.host.replace(':', '.'),
> > ud.path.replace('/', '.').replace('*', '.'))
> > +        gitsrcname = '%s%s' % (ud.host.replace(':', '.'),
> > ud.path.replace('/', '.').replace('*', '.').replace(" ", "%20"))
> >          if gitsrcname.startswith('.'):
> >              gitsrcname = gitsrcname[1:]
> >
> > @@ -459,7 +459,7 @@ class Git(FetchMethod):
> >              readpathspec = ""
> >              def_destsuffix = "git/"
> >
> > -        destsuffix = ud.parm.get("destsuffix", def_destsuffix)
> > +        destsuffix = ud.parm.get("destsuffix",
> > def_destsuffix).replace(" ", "%20")
> >          destdir = ud.destdir = os.path.join(destdir, destsuffix)
> >          if os.path.exists(destdir):
> >              bb.utils.prunedir(destdir)
> > @@ -574,7 +574,7 @@ class Git(FetchMethod):
> >              username = ud.user + '@'
> >          else:
> >              username = ""
> > -        return "%s://%s%s%s" % (ud.proto, username, ud.host,
> > ud.path)
> > +        return "%s://%s%s%s" % (ud.proto, username, ud.host,
> > ud.path.replace(" ", "%20"))
> >
> >      def _revision_key(self, ud, d, name):
> >          """
> > --
> > 2.22.0.windows.1
> >
>
> ------------------------------
>
> --
> _______________________________________________
> bitbake-devel mailing list
> bitbake-devel at lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/bitbake-devel
>
>
> End of bitbake-devel Digest, Vol 99, Issue 4
> ********************************************