[bitbake-devel] [PATCH 17/26] runqueue: Tweak comments and debug code

Richard Purdie richard.purdie at linuxfoundation.org
Wed Jul 10 23:54:11 UTC 2019


Add some extra comments to build_scenequeue_data() and fix the debug code
so it actually works.

Signed-off-by: Richard Purdie <richard.purdie at linuxfoundation.org>
---
 lib/bb/runqueue.py | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/lib/bb/runqueue.py b/lib/bb/runqueue.py
index 1f41340170..05bc9f9488 100644
--- a/lib/bb/runqueue.py
+++ b/lib/bb/runqueue.py
@@ -2360,6 +2360,7 @@ def build_scenequeue_data(sqdata, rqdata, rq, cooker, stampcache, sqrq):
 
     rqdata.init_progress_reporter.next_stage(len(rqdata.runtaskentries))
 
+    # Sanity check all dependencies could be changed to setscene task references
     for taskcounter, tid in enumerate(rqdata.runtaskentries):
         if tid in rqdata.runq_setscene_tids:
             deps = set()
@@ -2409,15 +2410,17 @@ def build_scenequeue_data(sqdata, rqdata, rq, cooker, stampcache, sqrq):
     rqdata.init_progress_reporter.next_stage()
 
     #for tid in sq_revdeps_squash:
+    #    data = ""
     #    for dep in sq_revdeps_squash[tid]:
     #        data = data + "\n   %s" % dep
-    #    bb.warn("Task %s_setscene: is %s " % (tid, data
+    #    bb.warn("Task %s_setscene: is %s " % (tid, data))
 
     sqdata.sq_deps = {}
     sqdata.sq_revdeps = sq_revdeps_squash
     sqdata.sq_revdeps2 = copy.deepcopy(sqdata.sq_revdeps)
     sqdata.sq_covered_tasks = sq_collated_deps
 
+    # Build reverse version of revdeps to populate deps structure
     for tid in sqdata.sq_revdeps:
         sqdata.sq_deps[tid] = set()
     for tid in sqdata.sq_revdeps:
-- 
2.20.1



More information about the bitbake-devel mailing list