[bitbake-devel] [PATCH] fetch2: add ability to skip recipes when get_srcrev fails via BB_FETCH_SKIP_ON_SRCREV_ERROR

[chris.laplante at agilent.com]

> -----Original Message-----
> From: Alexander Kanavin <alex.kanavin at gmail.com>
> Sent: Friday, July 26, 2019 11:06 AM
> To: LAPLANTE,CHRIS (Agilent USA) <chris.laplante at agilent.com>
> Cc: bitbake-devel <bitbake-devel at lists.openembedded.org>
> Subject: Re: [bitbake-devel] [PATCH] fetch2: add ability to skip recipes when get_srcrev fails via BB_FETCH_SKIP_ON_SRCREV_ERROR
> 
> I think it's better to rearrange the layer itself, and split it into a privileged and a non-privileged one.
> 

Yes, that's the "cleanest" solution, but it doesn’t necessarily scale well when you add more and more disjoint sets of users that can/can't access particular recipes. 

Also, just to add some more context to how we are using this: for each of our "skippable" recipes, we have alternative providers that pull pre-compiled artifacts from "pool" repositories. It is nice to keep the providers' recipes in one place.

> This patch seems to enable skipping the recipe, regardless of what the actual issue with fetching was (which may or may not be 'access
> denied'). Skipping on any error doesn't seem right to me as it may mask other types of problems.

I see your point (in general), but note that this only skips the recipe if an error occurs in get_srcrev during the parsing stage (and we are not executing in a task). The original exception will still be displayed to the user. 

But it certainly would be better to be more selective with which kind of errors get swallowed. I will try to look into that.

Thanks,
Chris