[bitbake-devel] UNVERIFIED SENDER Re: [PATCH] fetch2: add ability to skip recipes when get_srcrev fails via BB_FETCH_SKIP_ON_SRCREV_ERROR

chris.laplante at agilent.com chris.laplante at agilent.com
Mon Jul 29 15:14:03 UTC 2019


> I agree, I don't really like auto skipping in this case as it will make it
> difficult to determine or resolve issues from different users.
> 
> But I do wonder if this is a specific URL/SRCREV that isn't available to this
> user, or is this related to AUTOREV?
> 

It's a bit of both. For some of these recipes, the non-privileged users have access to the upstream source code using a different login name. For a handful of others, they have no access whatsoever.

For the former case, I have a class that rewrites the SRC_URIs in a RecipePreFinalise event handler. For the latter case I am currently using the following class (which turns out to be similar to what Richard suggested):

addhandler skip_eventhandler
python skip_eventhandler() {
    try:
        bb.fetch2.Fetch(d.getVar("SRC_URI").split(), d)
    except bb.fetch2.FetchError:
        raise bb.parse.SkipRecipe("skip-inaccessible: could not access upstream repo; check SRC_URI, access rights, and network availability")
}
skip_eventhandler[eventmask] = "bb.event.RecipePreFinalise"

I have heard and fully agree that such stuff shouldn't be in the core. It's certainly nothing I wanted to have to implement :)

However, I feel like it would be nice to have somewhere to document these kinds of real-world problems with non-optimal solutions, for the benefit of other people dealing with access controlled source code. Perhaps this email chain is documentation enough?

Thanks,
Chris


More information about the bitbake-devel mailing list