[bitbake-devel] [RFC PATCH] svn.py: Stop SVN from directly pulling from an external layer w/o fetcher

[richard.purdie at linuxfoundation.org]

On Thu, 2019-05-16 at 10:22 +0300, Mark Hatle wrote:
> On 5/16/19 9:41 AM, Richard Purdie wrote:
> > On Wed, 2019-05-15 at 14:02 -0400, Mark Hatle wrote:
> > > Add a new option to the svn fetcher url "externals=allowed".  This will allow
> > > a user to enable svn co w/ externals.  However, this does avoid the fetcher,
> > > network access and mirror systems.
> > > 
> > > By default we no longer allow externals in the checkout.  This ensures a
> > > deterministic download.  The system does attempt to identify SVN repos that
> > > have externals enabled, and will warn the user.
> > > 
> > > In the future we would like to parse this list and see if the items are already
> > > in the SRC_URI for that recipe, but with SVN being in limited use these days
> > > that extra work is likely not worth the trouble.
> > > 
> > > Add test cases that generated a local SVN tree, with an external source
> > > set to github bitbake in svn format.  One test case checks that externals are
> > > ignored, and one checks that they in downloaded.
> > > 
> > > Signed-off-by: Mark Hatle <mark.hatle at windriver.com>
> > > ---
> > >  This was done in response to the patch from Krzysztof Zawadzki and the resulting
> > >  discussion to make this the default instead of optional.
> > 
> > Patch looks good to me but the autobuilder didn't like it:
> > 
> > https://autobuilder.yoctoproject.org/typhoon/#/builders/56/builds/465/steps/7/logs/step1d
> 
> What is the host system type on the autobuilder?  Everything I see in the
> traceback is as intended.  So it's likely a version or argument change in a
> different version of SVN.

That one was debian9.

rpurdie at debian9-ty-2:~$ svn --version
svn, version 1.9.5 (r1770682)
   compiled Jul 21 2018, 02:35:40 on x86_64-pc-linux-gnu

Worryingly I looked on debian9-ty-1 first and subversion isn't
installed there at all. In builds we'd build subversion-native.

This could get quite tricky to handle...

Cheers,

Richard