[bitbake-devel] [PATCH v2] svn.py: Stop SVN from directly pulling from an external layer w/o fetcher

[Mark Hatle]

On 5/17/19 9:16 AM, Richard Purdie wrote:
> On Thu, 2019-05-16 at 06:46 -0400, Mark Hatle wrote:
>> Add a new option to the svn fetcher url "externals=allowed".  This will allow
>> a user to enable svn co w/ externals.  However, this does avoid the fetcher,
>> network access and mirror systems.
>>
>> By default we no longer allow externals in the checkout.  This ensures a
>> deterministic download.  The system does attempt to identify SVN repos that
>> have externals enabled, and will warn the user.  It is up to the user to
>> determine if these are necessary for the recipe.  They may disable the warning
>> by adding "externals=nowarn" to the url.
>>
>> In the future we would like to parse this list and see if the items are already
>> in the SRC_URI for that recipe, but with SVN being in limited use these days
>> that extra work is likely not worth the trouble.
>>
>> Add test cases that generated a local SVN tree, with an external source
>> set to github bitbake in svn format.  One test case checks that externals are
>> ignored, and one checks that they in downloaded.
>>
>> Signed-off-by: Mark Hatle <mark.hatle at windriver.com>
>> ---
>> v2:
>>  Refactored the test case to use --non-interactive option to try to avoid
>>  the controlling terminal failure.
> 
> I think this is working better but it leaves us with a second issue,
> not all our autobuilder workers have subversion installed:
> 
> https://autobuilder.yoctoproject.org/typhoon/#/builders/80/builds/177
> https://autobuilder.yoctoproject.org/typhoon/#/builders/86/builds/176
> https://autobuilder.yoctoproject.org/typhoon/#/builders/87/builds/175
> 
> (a pass: 
> https://autobuilder.yoctoproject.org/typhoon/#/builders/79/builds/180)
> 
> I did specifically test on debian 9 where we saw the problem last time
> and that issue is resolved and passes now.
> 
> The question now is whether we want to install subversion on all our
> workers, whether we download and install some kind of standalone test
> tarball for this test or whether we disable the test by default...

Is there a concept of a skipped test within bitbake-selftest?  It would be easy
enough for me to check if 'svn' and 'svnadmin' were available in the environment
and simply skip them.

Then it's up to you guys to figure out if this is a test you want to run on all
of the builders by installing svn or a standalone test tarball as you suggested.

--Mark

> Cheers,
> 
> Richard
> 
> 
>