[bitbake-devel] [PATCH] lib/bb: Add BB_SIGNATURE_LOCAL_DIRS_EXCLUDE to speed-up taskhash on directories

[Anibal Limon]

Regarding some comments in PATCHv2 where default value was set [1], I agree
that this patch will be better and then set default value
in oe-core.

[1]
http://lists.openembedded.org/pipermail/bitbake-devel/2019-November/020519.html

On Thu, 14 Nov 2019 at 12:08, Anibal Limon <anibal.limon at linaro.org> wrote:

>
>
> On Thu, 14 Nov 2019 at 12:07, Anibal Limon <anibal.limon at linaro.org>
> wrote:
>
>>
>> On Thu, 14 Nov 2019 at 10:54, Peter Kjellerstedt <
>> peter.kjellerstedt at axis.com> wrote:
>>
>>> > -----Original Message-----
>>> > From: bitbake-devel-bounces at lists.openembedded.org <bitbake-devel-
>>> > bounces at lists.openembedded.org> On Behalf Of Khem Raj
>>> > Sent: den 14 november 2019 03:55
>>> > To: Aníbal Limón <anibal.limon at linaro.org>
>>> > Cc: bitbake-devel <bitbake-devel at lists.openembedded.org>
>>> > Subject: Re: [bitbake-devel] [PATCH] lib/bb: Add
>>> > BB_SIGNATURE_LOCAL_DIRS_EXCLUDE to speed-up taskhash on directories
>>> >
>>> > On Wed, Nov 13, 2019 at 3:23 PM Aníbal Limón <anibal.limon at linaro.org>
>>> > wrote:
>>> > >
>>> > > The new BB_SIGNATURE_LOCAL_DIRS_EXCLUDE allows you to specify a list
>>> > > of directories to exclude when making taskhash, our specific case
>>> > > is using SRC_URI that points local VCS directory.
>>> > >
>>> > > In OE-Core this variable could be set by default to:
>>> > >
>>> > > BB_SIGNATURE_LOCAL_DIRS_EXCLUDE = ".cvs .git .svn"
>>>
>>> That should be:
>>>
>>> BB_SIGNATURE_LOCAL_DIRS_EXCLUDE = "CVS .git .svn"
>>>
>>
>> So I will change to,
>>
>> + self.localdirsexclude = (data.getVar("BB_SIGNATURE_LOCAL_DIRS_EXCLUDE")
>> or "CVS .git .svn").split()
>>
>> Any other directory to add it?
>>
>
> Replying myself...
>
> What about add all VCS directories that we support in fetcher.
>
>
>>
>> Cheers,
>> Anibal
>>
>>
>>>
>>> > I like the approach.  perhaps a sane default would be nice.
>>>
>>> //Peter
>>>
>>>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openembedded.org/pipermail/bitbake-devel/attachments/20191125/77bce721/attachment.html>